Font Library: Refactor as a singleton#58669
Conversation
youknowriad
added
Backport from WordPress Core
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/compat/wordpress-6.5/fonts/class-wp-font-library.php ❔ lib/compat/wordpress-6.5/fonts/class-wp-rest-font-collections-controller.php ❔ lib/compat/wordpress-6.5/fonts/fonts.php ❔ phpunit/tests/fonts/font-library/wpFontLibrary/base.php ❔ phpunit/tests/fonts/font-library/wpFontLibrary/getFontCollection.php ❔ phpunit/tests/fonts/font-library/wpFontLibrary/getFontCollections.php ❔ phpunit/tests/fonts/font-library/wpFontLibrary/registerFontCollection.php ❔ phpunit/tests/fonts/font-library/wpFontLibrary/unregisterFontCollection.php |
matiasbenedetto
left a comment
matiasbenedetto
left a comment
There was a problem hiding this comment.
I tested that the font collections functionality still works as expected:
✔️ Collections API endpoints work as expected
✔️ Collections can be registered
✔️ Collections can be unregistered
LGTM
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core SVNIf you're a Core Committer, use this list when committing to GitHub Merge commitsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
2 participants
What?
The FontLibrary class is basically a registry of font collections. And to map existing code style used for "registries" (block types, block patterns...) in Core, we're updating the class to use the singleton pattern rather than static methods.
No functional change here.
This backports a change from Core implemented in WordPress/wordpress-develop#6027